Skip to content

[spec] Validation for exact heap types#97

Merged
tlively merged 2 commits into
mainfrom
exact-heap-type-validation
Mar 3, 2026
Merged

[spec] Validation for exact heap types#97
tlively merged 2 commits into
mainfrom
exact-heap-type-validation

Conversation

@tlively
Copy link
Copy Markdown
Member

@tlively tlively commented Mar 2, 2026

Add Heaptype_ok/exact and Heaptype_sub/exact-l rules for exact heap
types in the spectec and in the doc.

Add Heaptype_ok/exact and Heaptype_sub/exact-l rules for exact heap
types in the spectec and in the doc.
@tlively tlively requested a review from rossberg March 2, 2026 19:28
Comment thread document/core/valid/types.rst Outdated
Comment on lines +61 to +63
$${rule-prose: Heaptype_ok/typeuse}

$${rule: Heaptype_ok/typeuse}
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this because it was missing, but I can take it back out if you prefer.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I intentionally left out rules that are just injections into a different judgement, i.e., where premise and conclusion look exactly the same. They are just formalities that I feel would cause more confusion than help for human readers.

@tlively tlively mentioned this pull request Mar 2, 2026
50 tasks
Copy link
Copy Markdown
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo comment

Comment thread document/core/valid/types.rst Outdated
Comment on lines +61 to +63
$${rule-prose: Heaptype_ok/typeuse}

$${rule: Heaptype_ok/typeuse}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I intentionally left out rules that are just injections into a different judgement, i.e., where premise and conclusion look exactly the same. They are just formalities that I feel would cause more confusion than help for human readers.

@tlively tlively merged commit b7b4a91 into main Mar 3, 2026
11 of 12 checks passed
@tlively tlively deleted the exact-heap-type-validation branch March 3, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants